Text to model docs #7595
Text to model docs #7595
Conversation
There was a problem hiding this comment.
Hi @perminder-17 thanks, it looks good, I just added a small comment about notation and a need for a small clarification, let me know your thoughts.
CC: @davepagurek @limzykenneth
| * 'vec4 getFinalColor': `(vec4 _c) { | ||
| * float x = vPos.x * 0.005; | ||
| * float a = floor(fract(x) * numColors); | ||
| * float b = a == numColors - 1. ? 0. : a + 1.; |
There was a problem hiding this comment.
Not sure if this was adressed before, but having the notation -1. might not be clear for all users, thinking that why not use just -1 or -1.0 I understand that we might need to explicitly cast it like this to indicate its a float to WEBGL but it might I think it would be useful to add a note as to why we choose to notate it like this. A brief comment would be good enough I believe
| * | ||
| * let prevWords = ''; | ||
| * let prevFont = ''; | ||
| * let prevExtrude = -1; |
There was a problem hiding this comment.
for example, why in the other cases we need an explicit float and not here? It might be confusing for some users.
No description provided.